Skip to content

Handle reliable stream send failures - #415

Merged
EugenioCollado merged 1 commit into
eProsima:masterfrom
Old-Ding:fix/reliable-send-failure-window
Jul 7, 2026
Merged

Handle reliable stream send failures#415
EugenioCollado merged 1 commit into
eProsima:masterfrom
Old-Ding:fix/reliable-send-failure-window

Conversation

@Old-Ding

@Old-Ding Old-Ding commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • stop reliable stream flushing when send_message reports a send failure
  • restore the prepared reliable buffer state so the same buffer can be retried on the next flush
  • add a regression test for failed reliable stream sends

Fixes #411.

Testing

  • git diff --check
  • git ls-files --eol src\c\core\session\session.c src\c\core\session\stream\output_reliable_stream.c src\c\core\session\stream\output_reliable_stream_internal.h test\unitary\session\Session.cpp

Not run: unit tests. This Windows environment does not have CMake or a C/C++ compiler available in PATH (cmake --version is not recognized; Get-Command cmake,gcc,g++,clang,clang++,cl,ninja,ctest found no commands).

Generated-by: OpenAI Codex
Signed-off-by: aineoae86-sys <ai.neo.ae86@gmail.com>

@EugenioCollado EugenioCollado left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EugenioCollado
EugenioCollado merged commit 6141d27 into eProsima:master Jul 7, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The return value of send_message is not checked

3 participants